feat: fixed intersection of focus skip and filters#327
Merged
andrii-a8c merged 5 commits intomainfrom Nov 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the conditional logic that determines how functions are categorized for verification purposes (focus specs, no focus specs, no verify specs, and abort handling). The main change restructures nested conditionals to properly handle the intersection of focus, prove, skip, and targeted flags.
Key Changes:
- Moved
ignore_aborthandling to execute before verification categorization logic - Restructured the conditional logic to first check
skipandtargetedflags, then categorize functions based onfocusandproveflags in a nested else block
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BigBadE
pushed a commit
that referenced
this pull request
Nov 19, 2025
* feat: fixed intersection of focus skip and filters * feat: removed redudant field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements: #236